Gene panel column data in patient view download #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pages/patientView/copyNumberAlterations/CopyNumberTableWrapper.tsx
Outdated
Show resolved
Hide resolved
src/shared/components/mutationTable/column/PanelColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
src/shared/components/mutationTable/column/PanelColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
ngocnn1104
force-pushed
the
gene_panel_download
branch
from
fd3d777
to
227d281
Compare
pvannierop
force-pushed
the
patientview_genepanel_api_integration
branch
from
279afdb
to
350d3e8
Compare
adamabeshouse
approved these changes
Oct 1, 2019
ngocnn1104
force-pushed
the
gene_panel_download
branch
from
227d281
to
d7c7173
Compare
ngocnn1104
changed the base branch from
patientview_genepanel_api_integration
to
patientview_filter_genome_overview
alisman
reviewed
Oct 15, 2019
| } | ||
|
|
||
| render() { | ||
| const { data, sampleToMutationGenePanelId } = this.props; |
There was a problem hiding this comment.
seems like there's some indentation issues here. you can run prettier.js on this file. see command in scripts of package.json
alisman
approved these changes
Oct 15, 2019
|
@ngocnn1104 @pvannierop can you guys explain what branch this is PR is targetting? |
ngocnn1104
force-pushed
the
gene_panel_download
branch
3 times, most recently
from
930deb8
to
4843f14
Compare
Hi @alisman, we will target the master branch eventually, but now some features relating to gene panel is still in development and they are dependent on one another. I added the |
ngocnn1104
force-pushed
the
gene_panel_download
branch
3 times, most recently
from
ed8b8d6
to
4581762
Compare
pvannierop
force-pushed
the
patientview_filter_genome_overview
branch
from
a850e35
to
9810e74
Compare
pvannierop
force-pushed
the
gene_panel_download
branch
from
4581762
to
5c9e64c
Compare
ngocnn1104
changed the base branch from
patientview_filter_genome_overview
to
master
ngocnn1104
force-pushed
the
gene_panel_download
branch
from
5c9e64c
to
7f36f2b
Compare
ngocnn1104
force-pushed
the
gene_panel_download
branch
from
7f36f2b
to
a5d0ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Implementation of feature: Gene panel column data in patient view download
Code changes
PanelColumnFormatter.tsxto render the related panel dataGene panelcolumn (hidden by default) toPatientViewMutationTable.tsxandCopyNumberTableWrapper.tsxGIF
Remarks:
patientview_genepanel_api_integrationwhich does not exist