Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing columns in mutation mapper table #2906

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Nov 27, 2019

adding exon, hgvd, gnomad, clinvar, dbsnp to mutation mapper table

fix: cBioPortal/cbioportal#6868

@leexgh leexgh force-pushed the missing-columns branch 3 times, most recently from 936abe6 to 33f917c Compare November 29, 2019 15:36
@leexgh leexgh marked this pull request as ready for review November 29, 2019 15:36
@leexgh leexgh changed the title add hgvsc gnomad and clinvar columns in mutation mapper table add missing columns in mutation mapper table Nov 29, 2019
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leexgh ! This solves the issue temporarily, but I think the actual issue is that we keep forgetting to add the shared columns in all three locations: Patient View, Mutations Tab and Mutation Mapper. To avoid that from happening again it might make sense to either:

  1. Introduce a variable that's called something like SHARED_MUTATION_COLUMNS and add that in all three places or
  2. Use inheritance and change the base class in some way to always include them

@inodb inodb merged commit d7ee076 into cBioPortal:master Nov 29, 2019
@inodb inodb added the bug label Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

columns missing from https://www.cbioportal.org/mutation_mapper
2 participants