Add Count Bubbles to Oncoprint Toolbar #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
reviewed
Dec 5, 2019
Luke-Sikina
force-pushed
the
oncoprint-needs-more-features
branch
from
a77f5b6
to
cb67fe5
Compare
alisman
approved these changes
Dec 5, 2019
|
@Luke-Sikina one more thing i just noticed: we want to change the button text from "Heatmaps" to "Add Heatmap Tracks" |
Luke-Sikina
force-pushed
the
oncoprint-needs-more-features
branch
from
cb67fe5
to
5ad0415
Compare
Good catch. Fixed. |
|
@Luke-Sikina just tested this and works great. just one more thing: see the missing space to the right of the clinical tracks bubble? |
Luke-Sikina
force-pushed
the
oncoprint-needs-more-features
branch
from
5ad0415
to
f54219e
Compare
Luke-Sikina
force-pushed
the
oncoprint-needs-more-features
branch
from
f54219e
to
a06e2c7
Compare
Luke-Sikina
force-pushed
the
oncoprint-needs-more-features
branch
from
a06e2c7
to
f713029
Compare
- added a count bubble for Clinical Tracks and Heatmaps - e2e fixes from change
Luke-Sikina
force-pushed
the
oncoprint-needs-more-features
branch
from
f713029
to
ba8115d
Compare
inodb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#6880
Describe changes proposed in this pull request:
Any screenshots or GIFs?