Bookmark feature should give user fullURL (and shortened version if b… #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itly enabled) so that all url params (not just session) are preserved
onursumer
reviewed
Dec 18, 2019
| @@ -21,6 +21,8 @@ export interface PortalSession { | |||
| } | |||
|
|
|||
| export function saveRemoteSession(data:any){ | |||
|
|
|||
| console.log("saving session", data); | |||
There was a problem hiding this comment.
do we want to keep this console.log?
onursumer
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookmark feature should allow user to bookmark even non-core (non-session) state params. Because those params CANNOT be saved to session right now, they are discarded
Fixes cBioPortal/cbioportal#6297