Update study links in results page query summary #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
requested changes
Dec 19, 2019
| samples: Pick<Sample, "sampleId" | "studyId">[], | ||
| hasVirtualStudies: boolean, | ||
| sampleLists?: Pick<SampleList, "category">[]) { | ||
| const hasAllCaseLists = _.some(sampleLists, sampleList => sampleList.category === 'all_cases_in_study'); | ||
| let studyViewFilterHash: string | undefined; | ||
| if (samples.length > 0 && (hasVirtualStudies || !hasAllCaseLists)) { | ||
| const sampleIdentifiers = samples.map(sample => ({ | ||
| sampleId: sample.sampleId, |
There was a problem hiding this comment.
If we are going to remove studyIds later on in study view, we better use uniqueSampleId here
There was a problem hiding this comment.
This is equivalent of sampleIdentifiers in StudyViewFilter, which doesn't support uniqueSampleIds
There was a problem hiding this comment.
Oh right, I misunderstood the structure. Sorry about that.
zhx828
approved these changes
Dec 19, 2019
alisman
reviewed
Dec 19, 2019
|
If I do a combined query and select a subset of patients, i see the wrong count in study name. I think below, the study name should be Combined Study (142 Samples)
|
|
@kalletlak i'm pretty sure it should be yes. it's exactly the same scenario (where a user has chosen studies and then selected a case list) |
|
@alisman updated |
alisman
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#6925