Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve footer version logic #2945

Merged
merged 2 commits into from
Dec 20, 2019
Merged

improve footer version logic #2945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c04d11
improve footer version logic
inodb Dec 19, 2019
bc1a79a
fix typo
inodb Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/AppStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ export class AppStore {
invoke:async()=>{
const portalVersionResult = await internalClient.getInfoUsingGET({});
if (portalVersionResult && portalVersionResult.portalVersion) {
return Promise.resolve("v" + portalVersionResult.portalVersion.split('-')[0]);
let version = portalVersionResult.portalVersion.split('-')[0];
if (!version.startsWith("v")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startsWith is probably not supported in IE. I'll test it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind it works and we use this elsewhere

version = `v${version}`;
}
return Promise.resolve(version);
}
return undefined;
}
Expand Down