Fix cursor issue with oql editor and improve styling and behavior #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
force-pushed
the
fixQuery
branch
4 times, most recently
from
c640b9a
to
e448ea5
Compare
alisman
changed the title
alisman
commented
Jan 14, 2020
| @@ -133,11 +133,6 @@ export default class GeneSetSelector extends QueryStoreComponent<{}, {}> { | |||
| <i className={'fa fa-external-link'} /> | |||
| </a> | |||
| } | |||
| promises={[ | |||
There was a problem hiding this comment.
don't want to show loader anymore. it's pointless and distracting to typing user
jjgao
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor would sometimes skip to the end during typing when validation service responded with certain timing in relation to further typing.
Also applied a minimum height to the validation error tokens the appear below textarea when a user types a nonexistant or ambiguous gene name. This allows bubbles to appear without forcing other elements to move.