Add quick oql edit feature to results view page next to current gene list #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamabeshouse gonna add a e2e test for this when approved by product |
adamabeshouse
approved these changes
Jan 17, 2020
|
Since the edit dialog will only be visible after click edit, can we make it bigger, e.g. the same height as in Query?
|
|
Also, if I click edit and them click "Modify Query", the "quick edit" dialog should be closed. |
alisman
force-pushed
the
oqlEdit
branch
2 times, most recently
from
436e1bd
to
762cf14
Compare
alisman
force-pushed
the
oqlEdit
branch
2 times, most recently
from
d259b1a
to
49afa7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pencil button near gene list in results page which opens interface for quickly modifying the oql of the query.