In localdb e2e tests, don't unnecessarily restart database #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
reviewed
Jan 22, 2020
| -e MYSQL_PASSWORD=$DB_PASSWORD \ | ||
| -e MYSQL_DATABASE=$DB_PORTAL_DB_NAME \ | ||
| -v "$DB_DATA_DIR:/var/lib/mysql/" \ | ||
| mysql:5.7 |
There was a problem hiding this comment.
@alisman is the restart slow? I guess Q is "how does this part benefit local testing"
There was a problem hiding this comment.
@inodb For some reason this causes things to fail for me. Everything works fine without it. A while back @pvannierop said he didn't recall why this was necessary and was ok with our removing it
There was a problem hiding this comment.
No, its fine to remove this.
pvannierop
approved these changes
Jan 27, 2020
| -e MYSQL_PASSWORD=$DB_PASSWORD \ | ||
| -e MYSQL_DATABASE=$DB_PORTAL_DB_NAME \ | ||
| -v "$DB_DATA_DIR:/var/lib/mysql/" \ | ||
| mysql:5.7 |
There was a problem hiding this comment.
No, its fine to remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear why this db restart was left in. It does not appear to be necessary.