Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate genome nexus cache for mutation assessor #3024

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Add separate genome nexus cache for mutation assessor #3024

merged 1 commit into from
Jan 30, 2020

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented Jan 30, 2020 •
edited
Loading

have a separate cache for mutation assessor, each column in functional impact loading separately, so can show sift and polyphen before mutation assessor was fetched completely

image

fix cBioPortal/cbioportal#6867

@alisman alisman requested a review from inodb January 30, 2020 16:33
inodb
inodb approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@alisman alisman merged commit d491301 into cBioPortal:master Jan 30, 2020
@inodb inodb added performance This PR is related to a performance issue and removed enhancement labels Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb approved these changes

Assignees
No one assigned
Labels
performance This PR is related to a performance issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hgvsc column shouldn't wait for mutation_assessor
3 participants
@alisman @inodb @leexgh