Handle 403 errors properly in global fashion #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
commented
Jan 30, 2020
| @@ -23,7 +23,7 @@ export class AppStore { | |||
| sendSentryMessage('ERRORHANDLER:' + error); | |||
| } catch (ex) {} | |||
|
|
|||
| if (error.status && /400|500/.test(error.status)) { | |||
| if (error.status && /400|500|403/.test(error.status)) { | |||
There was a problem hiding this comment.
really we should just handle everything that bubbles up here but i'm not quite ready to do so because there are some endpoints which say 404 to indicate no match (e.g quick search). So, need to do some more testing
inodb
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were showing blank screen on this 403 error. Should show global error screen
https://genie-private.cbioportal.org/study/summary?id=5e32067be4b01beff45d8174