Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix samples briefly showing up as unprofiled on patient view tab #3036

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Fix samples briefly showing up as unprofiled on patient view tab #3036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/pages/patientView/PatientViewPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,9 @@ export default class PatientViewPage extends React.Component<
this.patientViewPageStore
.sampleToMutationGenePanelId
.isComplete &&
this.patientViewPageStore
.genePanelIdToEntrezGeneIds
alisman marked this conversation as resolved.
Show resolved Hide resolved
.isComplete &&
!!sampleManager && (
<div data-test="patientview-mutation-table">
<PatientViewMutationTable
Expand Down Expand Up @@ -1098,6 +1101,9 @@ export default class PatientViewPage extends React.Component<

{this.patientViewPageStore.studyIdToStudy
.isComplete &&
this.patientViewPageStore
.genePanelIdToEntrezGeneIds
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CNA data also depends on genePanelIdToEntrezGeneIds: https://github.com/cBioPortal/cbioportal-frontend/blob/master/src/pages/patientView/clinicalInformation/PatientViewPageStore.ts#L1273

.isComplete &&
this.patientViewPageStore.referenceGenes
.isComplete && (
<div data-test="patientview-copynumber-table">
Expand Down