Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error while calculating profiled samples count #3041

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix error while calculating profiled samples count #3041

merged 1 commit into from
Feb 6, 2020

Conversation

kalletlak
Copy link
Member

@kalletlak kalletlak requested a review from zhx828 February 5, 2020 21:31
zhx828
zhx828 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the clean up. What's actual cause of this issue?

@kalletlak
Copy link
Member Author

Previously UniqueKey.MUTATED_GENES_TABLE were used for chart unique keys. But with recent changes to study-view filter, this has been changed to concatenated molecular profile ids

@zhx828 zhx828 merged commit f06ac2c into cBioPortal:master Feb 6, 2020
@inodb inodb added bug cl-bug Bug section of changelog. Bug fix and removed bug labels Feb 6, 2020
@kalletlak kalletlak deleted the fix-7120 branch July 8, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhx828 zhx828 zhx828 approved these changes

Assignees
No one assigned
Labels
cl-bug Bug section of changelog. Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Study View: Incorrect profiled samples count in charts dropdown
3 participants
@kalletlak @zhx828 @inodb