Add windows dev info to README #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
approved these changes
Feb 6, 2020
ecerami
reviewed
Feb 6, 2020
README.md
Outdated
| @@ -19,6 +19,8 @@ Make sure you have installed the node version and yarn version specified in | |||
|
|
|||
| **Tip:** You might want to use [nvm: Node Version Manager](https://github.com/nvm-sh/nvm) and [yvm: Yarn Version Manager](https://yvm.js.org/docs/overview) to switch between versions more easily. | |||
|
|
|||
| **Tip:** There are some known hiccups running the frontend on Windows see [run on Windows section](#Run-on-Windows) | |||
There was a problem hiding this comment.
The hiccups are are actually only related to running the tests, and also only related to Ubuntu running in Windows via WSL. Suggest that we move the this text to the test section, and modify to say: There are some known hiccups running the frontend tests on Ubuntu via Windows Subsystem for Linux (WSL). For details, see run on WSL section
ecerami
reviewed
Feb 6, 2020
Co-Authored-By: ecerami <[email protected]>
|
Thanks for reviewing @ecerami - changed it to a single line in the test section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @ecerami's experiences