Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨Refactor code: retrieve ndex tooltip information dynamically #4847

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

SAHU-01
Copy link
Contributor

@SAHU-01 SAHU-01 commented Feb 13, 2024

Fix cBioPortal/cbioportal#10595 (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • Using this endpoint to populate the Ndex Cancer Pathways tooltip rather than hardcoding it as it is now
  • Not finding the exact match for hardcoded URLs in endpoint, currently all URLs point to "#" (can be adjusted after discussion)

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Before:
image

After:
image

Notify reviewers

@inodb
Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 5985f27
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/65dcbc5a519295000801f752
😎 Deploy Preview https://deploy-preview-4847--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inodb inodb requested review from onursumer and alisman and removed request for onursumer February 14, 2024 15:54
Copy link
Collaborator

@alisman alisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR! Would be good to use our remoteData/mobxpromise solution for handling data fetching state

@SAHU-01 SAHU-01 force-pushed the ndex_tooltip_dynamic_retrival branch from 27f26ea to c7902ae Compare February 16, 2024 13:23
@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Feb 16, 2024

@alisman I've made the changes requested, for handling data fetching state.
Apart from that, regarding the difference in URLs present in the hardcoded - static code and the endpoint, I've added the endpoint URLs. [I still haven't removed the commented static code]
Please review the changes and let me know if any further adjustments are needed.
-- Thanks!

@alisman
Copy link
Collaborator

alisman commented Feb 16, 2024

@SAHU-01 we really appreciate you doing this work for us. I will be out of the office next week. If you have any questions about my change requests, please ask @onursumer. Sorry I didn't catch the second round of requests earlier. FYI @inodb

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Feb 17, 2024

@alisman I've made the changes requested.
Please review the changes and let me know if any further adjustments are needed!

@inodb inodb requested a review from onursumer February 19, 2024 17:05
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few more minor requests.

@alisman alisman merged commit 3e541b5 into cBioPortal:master Feb 26, 2024
13 of 15 checks passed
TJMKuijpers pushed a commit to TJMKuijpers/cbioportal-frontend that referenced this pull request Feb 28, 2024
…rtal#4847)

* 🔨Refactor code: retrieve ndex tooltip information dynamically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retrieve ndex tooltip information dynamically
4 participants