-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨Refactor code: retrieve ndex tooltip information dynamically #4847
🔨Refactor code: retrieve ndex tooltip information dynamically #4847
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR! Would be good to use our remoteData/mobxpromise solution for handling data fetching state
27f26ea
to
c7902ae
Compare
@alisman I've made the changes requested, for handling data fetching state. |
@SAHU-01 we really appreciate you doing this work for us. I will be out of the office next week. If you have any questions about my change requests, please ask @onursumer. Sorry I didn't catch the second round of requests earlier. FYI @inodb |
@alisman I've made the changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few more minor requests.
…rtal#4847) * 🔨Refactor code: retrieve ndex tooltip information dynamically
Fix cBioPortal/cbioportal#10595 (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Before:
After:
Notify reviewers
@inodb
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR