refactored test cases to use async and await #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
reviewed
Jun 4, 2024
| 'button[data-test="sampleGroupComparisonCreateGroupButton"]'; | ||
| const PatientCreateGroupButton = | ||
| 'button[data-test="patientGroupComparisonCreateGroupButton"]'; | ||
| const getSampleCreateGroupButton = async function() { |
There was a problem hiding this comment.
i don't think you need to wrap these in fuctions. enough to use getElementByTestHandle directly.
alisman
reviewed
Jun 4, 2024
bemijonathan
force-pushed
the
feature/bemijonathan-improve-logical-remote-tests
branch
from
b32cee7
to
7b26d63
Compare
bemijonathan
force-pushed
the
feature/bemijonathan-improve-logical-remote-tests
branch
from
7b26d63
to
fb00e3f
Compare
bemijonathan
force-pushed
the
feature/bemijonathan-improve-logical-remote-tests
branch
from
f73fe53
to
cb88996
Compare
alisman
reviewed
Jun 6, 2024
| }); | ||
|
|
||
| it('select from sample venn diagram', function() { | ||
| it('select from sample venn diagram', async function() { | ||
| jsApiClick('rect[data-test="sample0VennRegion"]'); |
There was a problem hiding this comment.
jsApiClick will need to be awaited
alisman
reviewed
Jun 6, 2024
| (await getElement(SampleCreateGroupButton)).click(); | ||
| await getElement('div.rc-tooltip-inner', { timeout: 20000 }); | ||
| await browser.pause(200); | ||
| const el = await getElement( |
There was a problem hiding this comment.
lets try to convert these to getElementByTestHandle (whenever you see we are using data-test)
bemijonathan
added a commit
to bemijonathan/cbioportal-frontend
that referenced
this pull request
Jun 26, 2024
* refactor test cases to use async and await
bemijonathan
added a commit
to bemijonathan/cbioportal-frontend
that referenced
this pull request
Jul 17, 2024
#1) * Update Genome Nexus API model and reVUE reference to fit new model (cBioPortal#4919) * Update Genome Nexus API model * Update revue reference to fit new model * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * move sync to async * move all customTabs to async * move all customTabs to async * move all expressionComparison to async * move all genomicEvolotion to async * move all groupComparison to async * move all groupComparison to async * move all results.logic to async * move all redirect to async * move all quickSearch to async * convert plots to async * move all patient.spec.js to async * move all oncoprinter.spec.js to async * move async to async migration home.spec.js mutation-mapper-tool.spec.js mutationsTab.spec.js * move sync to async migration oncoprinterColorConfig.spec.js mutationTable.spec.js * refactored test cases to use async and await (cBioPortal#4918) * refactor test cases to use async and await * fix newsletter link in banner * fix newsletter link in sidebar * Remove demo-rfc72 reference from local e2e test * retest and refactor few changes * last refactoring except comparisonTab * tiny refactorings
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR