Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swapping generic assay profiles in comparison view #4922

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix swapping generic assay profiles in comparison view #4922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6efbdf7
Fix swapping generic assay profiles in comparison view
MatthijsPon Jun 12, 2024
25fc31c
Remove unused GenericAssayEnrichments.tsx
MatthijsPon Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 0 additions & 125 deletions src/pages/groupComparison/GenericAssayEnrichments.tsx
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions src/shared/lib/comparison/ComparisonStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,14 +1699,14 @@ export default abstract class ComparisonStore extends AnalysisStore
readonly gaEnrichmentGroupsByAssayType = remoteData({
await: () => [
this
.selectedGenericAssayEnrichmentProfileMapGroupedByGenericAssayType,
.selectedAllGenericAssayEnrichmentProfileMapGroupedByGenericAssayType,
dippindots marked this conversation as resolved.
Show resolved Hide resolved
this.enrichmentAnalysisGroups,
],
invoke: () => {
return Promise.resolve(
_.mapValues(
this
.selectedGenericAssayEnrichmentProfileMapGroupedByGenericAssayType
.selectedAllGenericAssayEnrichmentProfileMapGroupedByGenericAssayType
.result!,
selectedGenericAssayEnrichmentProfileMap => {
let studyIds = Object.keys(
Expand Down Expand Up @@ -1850,7 +1850,7 @@ export default abstract class ComparisonStore extends AnalysisStore
await: () => [
this.gaEnrichmentGroupsByAssayType,
this
.selectedGenericAssayEnrichmentProfileMapGroupedByGenericAssayType,
.selectedAllGenericAssayEnrichmentProfileMapGroupedByGenericAssayType,
],
invoke: () => {
return Promise.resolve(
Expand All @@ -1866,7 +1866,7 @@ export default abstract class ComparisonStore extends AnalysisStore
sample => ({
caseId: sample.sampleId,
molecularProfileId: this
.selectedGenericAssayEnrichmentProfileMapGroupedByGenericAssayType
.selectedAllGenericAssayEnrichmentProfileMapGroupedByGenericAssayType
.result![genericAssayType][
sample.studyId
].molecularProfileId,
Expand Down Expand Up @@ -1973,7 +1973,7 @@ export default abstract class ComparisonStore extends AnalysisStore
await: () => [],
getSelectedProfileMap: () =>
this
.selectedGenericAssayEnrichmentProfileMapGroupedByGenericAssayType
.selectedAllGenericAssayEnrichmentProfileMapGroupedByGenericAssayType
.result![genericAssayType], // returns an empty array if the selected study doesn't have any generic assay profiles
fetchData: () => {
if (
Expand Down
Loading