Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e tests after microbiome generic assay removed #4946

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix e2e tests after microbiome generic assay removed #4946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...te/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
43 changes: 0 additions & 43 deletions end-to-end-test/remote/specs/core/comparisonTab.screenshot.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,49 +367,6 @@ describe('results view comparison tab screenshot tests', function() {
);
assertScreenShotMatch(res);
});

it('results view comparison tab microbiome signature tab several groups', function() {
goToUrlAndSetLocalStorage(
`${CBIOPORTAL_URL}/results/comparison?Action=Submit&RPPA_SCORE_THRESHOLD=2.0&Z_SCORE_THRESHOLD=2.0&cancer_study_list=blca_tcga_pan_can_atlas_2018&case_set_id=blca_tcga_pan_can_atlas_2018_cnaseq&comparison_selectedGroups=%5B"CDKN2A"%2C"MDM2"%2C"MDM4"%5D&comparison_subtab=generic_assay_microbiome_signature&data_priority=0&gene_list=CDKN2A%2520MDM2%2520MDM4&geneset_list=%20&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=blca_tcga_pan_can_atlas_2018_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=blca_tcga_pan_can_atlas_2018_mutations&profileFilter=0&tab_index=tab_visualize`
);
$(
'div[data-test="GroupComparisonGenericAssayEnrichments"]'
).waitForDisplayed({ timeout: 10000 });
$('b=Polyomavirus').waitForDisplayed({ timeout: 10000 });
$('b=Polyomavirus').click();
$('div[data-test="MiniBoxPlot"]').waitForDisplayed({
timeout: 20000,
});
$('body').moveTo({ xOffset: 0, yOffset: 0 });
var res = browser.checkElement(
'.msk-tab:not(.hiddenByPosition)',
'',
{
hide: ['.qtip'],
}
);
assertScreenShotMatch(res);
});

it('results view comparison tab microbiome signature tab two groups', function() {
// deselect a group
$('button[data-test="groupSelectorButtonMDM4"]').click();

$(
'div[data-test="GroupComparisonGenericAssayEnrichments"]'
).waitForDisplayed({ timeout: 10000 });
$('b=Wolbachia').waitForDisplayed({ timeout: 10000 });
$('b=Wolbachia').click();
$('body').moveTo({ xOffset: 0, yOffset: 0 });
var res = browser.checkElement(
'.msk-tab:not(.hiddenByPosition)',
'',
{
hide: ['.qtip'],
}
);
assertScreenShotMatch(res);
});
});

describe('delete group from session', function() {
Expand Down
48 changes: 0 additions & 48 deletions end-to-end-test/remote/specs/core/groupComparison.screenshot.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,54 +385,6 @@ describe('group comparison page screenshot tests', function() {
assertScreenShotMatch(res);
});

it('group comparison page microbiome signature tab several groups', function() {
// use study blca_tcga_pan_can_atlas_2018 for microbiome signature tests
goToUrlAndSetLocalStorage(
`${CBIOPORTAL_URL}/comparison/generic_assay_microbiome_signature?sessionId=5d63f222e4b0d777deb05c78&unselectedGroups=%5B%22NA%22%5D`
);
$(
'div[data-test="GroupComparisonGenericAssayEnrichments"]'
).waitForDisplayed({ timeout: 10000 });
$(
'div[data-test="GroupComparisonGenericAssayEnrichments"]'
).waitForDisplayed({ timeout: 10000 });
$('b=Collimonas').waitForDisplayed({ timeout: 10000 });
$('b=Collimonas').click();
$('div[data-test="MiniBoxPlot"]').waitForDisplayed({
timeout: 20000,
});
$('body').moveTo({ xOffset: 0, yOffset: 0 });
var res = browser.checkElement(
'.msk-tab:not(.hiddenByPosition)',
'',
{
hide: ['.qtip'],
}
);
assertScreenShotMatch(res);
});

it('group comparison page microbiome signature tab two groups', function() {
// use study blca_tcga_pan_can_atlas_2018 for microbiome signature tests
goToUrlAndSetLocalStorage(
`${CBIOPORTAL_URL}/comparison/generic_assay_microbiome_signature?sessionId=5d63f222e4b0d777deb05c78&unselectedGroups=%5B%22NA%22%2C%22White%22%5D`
);
$(
'div[data-test="GroupComparisonGenericAssayEnrichments"]'
).waitForDisplayed({ timeout: 10000 });
$('b=Lawsonia').waitForDisplayed({ timeout: 10000 });
$('b=Lawsonia').click();
$('body').moveTo({ xOffset: 0, yOffset: 0 });
var res = browser.checkElement(
'.msk-tab:not(.hiddenByPosition)',
'',
{
hide: ['.qtip'],
}
);
assertScreenShotMatch(res);
});

it('group comparison page mutations tab two groups', function() {
goToUrlAndSetLocalStorage(
`${CBIOPORTAL_URL}/comparison/mutations?sessionId=5cf89323e4b0ab413787436c&selectedGene=AR`
Expand Down
9 changes: 8 additions & 1 deletion end-to-end-test/remote/specs/core/studyview.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,9 @@ describe('submit genes to results view query', () => {
goToUrlAndSetLocalStorage(url);
waitForNetworkQuiet();
});
it('generic assay chart should be added in the summary tab', function() {
// this relies on the micbiobiome signature generic assay
// which no longer exists (data retracted)
it.skip('generic assay chart should be added in the summary tab', function() {
this.retries(0);
browser.waitUntil(
() =>
Expand All @@ -736,10 +738,15 @@ describe('submit genes to results view query', () => {
);
$(ADD_CHART_BUTTON).click();

browser.debug();

// Change to GENERIC ASSAY tab
$(ADD_CHART_GENERIC_ASSAY_TAB).waitForDisplayed({
timeout: WAIT_FOR_VISIBLE_TIMEOUT,
});

browser.debug();

$(ADD_CHART_GENERIC_ASSAY_TAB).click();

// wait for generic assay data loading complete
Expand Down
Loading