Fix plots tab related data loading on initial study view load #4958
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -3750,7 +3754,7 @@ export default class PlotsTab extends React.Component<IPlotsTabProps, {}> { | |||
| options = options.filter(stringCompare).slice(0, 10); | |||
| const genes = await fetchGenes(options.map(o => o.label)); | |||
| const coverageInformationPromise = getCoverageInformation( | |||
| this.props.genePanelDataForAllProfiles!, | |||
| this.props.genePanelDataForAllProfiles?.result || [], | |||
There was a problem hiding this comment.
can we make sure that we're awaiting result properly and then use ! to assert it isntead of ?. in other words, using ? implies that we aren't sure it's loaded yet, and we should be sure.
| this.props.hugoGeneSymbols, | ||
| Array.isArray(this.props.hugoGeneSymbols) | ||
| ? this.props.hugoGeneSymbols | ||
| : this.props.hugoGeneSymbols.result, |
There was a problem hiding this comment.
seems strange. i guess this is due to fact that it's used differently in different places. but there should be a better way to handle this.
| } | ||
| hugoGeneSymbols={ | ||
| allHugoGeneSymbols={ |
There was a problem hiding this comment.
Hi Bryan, sorry it took me SO long to respond. This is quite confusing to have a property hugeGeneSymbols AND allHugeGeneSymbols. Lets think if there's some better we can handle this.
There was a problem hiding this comment.
The basic problem is that we need to wait for the gene symbols to load but we only want to do that when the tab is actually showing. We can handle that more elegantly with some kind of loading wrapper. Maybe we can do a pair programming session and figure it out.
Fix cBioPortal/cbioportal#10897