Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Patient and Sample Resources to Study View #4961

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Nelliney
Copy link
Contributor

@Nelliney Nelliney commented Aug 8, 2024

  1. Add a new tab, "Files & Links," to the Study View.
  2. In the tab, add a searchable table that displays patient and sample resources, the type and description of resources, and the number of resources per patient.
  3. Add the total number of resources in the study at the top of the page.
  4. Define the behavior for when this tab is displayed.
  5. Enhance the user interface by adding borders, icons, and a title to the table.
  6. Add threshold so it only works for cohorts with max 500 patients. We don't have a GET or POST request API to get all patient and sample resources in a study atm, so this is to avoid having to make >500 GET Requests

Screenshot 2024-08-08 at 12 31 13

@Nelliney Nelliney requested a review from inodb August 8, 2024 23:16
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 3912e62
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/66c8d541eff9ab00085b5a41
😎 Deploy Preview https://deploy-preview-4961--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inodb inodb changed the title Resource data enhancements #4959 Resource data enhancements Aug 9, 2024
@inodb inodb changed the title Resource data enhancements Add Patient and Sample Resources to Study View Aug 9, 2024
src/pages/studyView/resources/FilesAndLinks.tsx Outdated Show resolved Hide resolved
src/pages/studyView/resources/FilesAndLinks.tsx Outdated Show resolved Hide resolved
src/pages/studyView/StudyViewPage.tsx Show resolved Hide resolved
src/pages/studyView/resources/FilesAndLinks.tsx Outdated Show resolved Hide resolved
src/pages/studyView/resources/FilesAndLinks.tsx Outdated Show resolved Hide resolved
src/pages/studyView/resources/FilesAndLinks.tsx Outdated Show resolved Hide resolved
src/pages/studyView/resources/FilesAndLinks.tsx Outdated Show resolved Hide resolved
src/pages/studyView/resources/FilesAndLinks.tsx Outdated Show resolved Hide resolved
src/shared/api/urls.ts Outdated Show resolved Hide resolved
@alisman
Copy link
Collaborator

alisman commented Aug 14, 2024

@Nelliney somehow some other commits made it into this PR. I think maybe you merged master into it. Can you try rebasing instead? Let me know if you need help with this as it can be tricky.

@Nelliney
Copy link
Contributor Author

@alisman, thank you for letting me know. I did a rebase yesterday, and now I have synced my fork, and I believe that it should be solved. Please let me know if you have any comments or requests.

@alisman alisman merged commit 76e378e into cBioPortal:master Aug 23, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants