CustomButtons: fix studyName missing when viewing under ResultsViewPage #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sultsViewPage - this adds to the current support for loading under GroupComparisonPage - Prior to this, under ResultsViewPage, the CustomButton would launch with the generic value "studyName == cBioPortal Data"
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
approved these changes
Aug 26, 2024
Nelliney
pushed a commit
to Nelliney/cbioportal-frontend
that referenced
this pull request
Sep 18, 2024
…ge (cBioPortal#4982) * CustomButton: add support for extracting studyName when loading in ResultsViewPage - this adds to the current support for loading under GroupComparisonPage - Prior to this, under ResultsViewPage, the CustomButton would launch with the generic value "studyName == cBioPortal Data" * Prettier --------- Co-authored-by: Denis Papp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching a custom URL with the CustomButtons, the code extracts the "studyName" from the page context and passes it along. This was only working in the GroupComparisonPage context. The CustomButtons can also appear under the ResultsViewPage. This PR fixes that case.
This commit also sets studyName ="Combined Study" in the case where there are 2+ studies, following the pattern used elsewhere.
Checks
Notify reviewers
@alisman