Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC85 Dynamic Virtual Study #5016

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

forus
Copy link
Contributor

@forus forus commented Oct 2, 2024

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • Added option to select a dynamic type of virtual study while creating it
  • Static type (the legacy one) is the default one

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Added option to select a dynamic type of virtual study while creating it

Static type (the legacy one) is the default one
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 869cf79
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/672a8606be58800008e019a3
😎 Deploy Preview https://deploy-preview-5016.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

To make it follow the conventions and escape confusion
with java bean property convenction during deserialisation on BE
Copy link
Member

@pieterlukasse pieterlukasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @forus !
I added some proposals to improve the tooltip text.

src/pages/studyView/virtualStudy/VirtualStudy.tsx Outdated Show resolved Hide resolved
src/pages/studyView/virtualStudy/VirtualStudy.tsx Outdated Show resolved Hide resolved
src/pages/studyView/virtualStudy/VirtualStudy.tsx Outdated Show resolved Hide resolved
@forus
Copy link
Contributor Author

forus commented Oct 23, 2024

@alisman @haynescd @pieterlukasse I've changed code to provide different descriptions for static and dynamic Virtual Study by default. Check 4b49f4f

@forus forus removed the DO NOT MERGE label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants