-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RFC85 Dynamic Virtual Study #5016
base: master
Are you sure you want to change the base?
Conversation
Added option to select a dynamic type of virtual study while creating it Static type (the legacy one) is the default one
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To make it follow the conventions and escape confusion with java bean property convenction during deserialisation on BE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @forus !
I added some proposals to improve the tooltip text.
Co-authored-by: pieterlukasse <[email protected]>
@alisman @haynescd @pieterlukasse I've changed code to provide different descriptions for static and dynamic Virtual Study by default. Check 4b49f4f |
Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR