Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce api calls for generic assay meta in study view page #5019

Open
wants to merge 1 commit into
base: clickhouse
Choose a base branch
from

Conversation

dippindots
Copy link
Member

No description provided.

@dippindots dippindots added the performance This PR is related to a performance issue label Oct 11, 2024
@dippindots dippindots self-assigned this Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for cbioportalfrontend failed. Why did it fail? →

Name Link
🔨 Latest commit 2b27301
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/670e078144041400086bb3d1

this.genericAssayProfiles.result
);
},
});

readonly genericAssayStableIdToMeta = remoteData<{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reference, deleting this function

@dippindots dippindots force-pushed the generic-assay-meta-study-view-reduce-call branch 3 times, most recently from b7d4fa5 to 2b27301 Compare October 15, 2024 06:11
@alisman alisman changed the base branch from master to clickhouse October 17, 2024 16:34
@dippindots dippindots force-pushed the generic-assay-meta-study-view-reduce-call branch from 2b27301 to 73f2ebe Compare October 17, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance This PR is related to a performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant