-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/news route should go to configured news page #10632
Comments
@inodb in the application.properties file, to the skin.documentation.news property, the .md file assigned based on the instance [ex. News.md for cbioportal.org/news and News-Genie.md for genie.cbioportal.org/news], is likely the configuration property currently used. For any local instance as long as the documentation is followed, I believe this logic would work, do you still suggest setting up of a new configuration for /news route? |
Fix #10632. Use frontend's existing redirect logic: cBioPortal/cbioportal-frontend#4342
@SAHU-01 Great digging! Thank you! I see, so it's handled by the fronted atm, see e.g. https://frontend.cbioportal.org/news. But doesn't work when accessing thru the backend, https://cbioportal.org/news I filed a PR for this, so it just passes it on to be handled at the frontend: #10658 |
* Fix News Page redirect Fix #10632. Use frontend's existing redirect logic: cBioPortal/cbioportal-frontend#4342
e.g.
cbioportal.org/news -> https://docs.cbioportal.org/news/
genie.cbioportal.org/news -> https://docs.cbioportal.org/news-genie/
I guess the GENIE example might change in the future (as we might have a single instance), but it would still be useful that the news route would go to the configured news page for other local installations
There might be a configuration property already as the current News button on genie.cbioportal.org does go to the correct page
The text was updated successfully, but these errors were encountered: