Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/news route should go to configured news page #10632

Closed
inodb opened this issue Feb 15, 2024 · 2 comments · Fixed by #10658
Closed

/news route should go to configured news page #10632

inodb opened this issue Feb 15, 2024 · 2 comments · Fixed by #10658

Comments

@inodb
Copy link
Member

inodb commented Feb 15, 2024

e.g.

cbioportal.org/news -> https://docs.cbioportal.org/news/

genie.cbioportal.org/news -> https://docs.cbioportal.org/news-genie/

I guess the GENIE example might change in the future (as we might have a single instance), but it would still be useful that the news route would go to the configured news page for other local installations

There might be a configuration property already as the current News button on genie.cbioportal.org does go to the correct page

@SAHU-01
Copy link

SAHU-01 commented Feb 16, 2024

@inodb in the application.properties file, to the skin.documentation.news property, the .md file assigned based on the instance [ex. News.md for cbioportal.org/news and News-Genie.md for genie.cbioportal.org/news], is likely the configuration property currently used.
A proof of which can be found in here.
And this PR 4342 does the rest of frontend task.

For any local instance as long as the documentation is followed, I believe this logic would work, do you still suggest setting up of a new configuration for /news route?

inodb added a commit that referenced this issue Feb 21, 2024
Fix #10632. Use frontend's existing redirect logic: cBioPortal/cbioportal-frontend#4342
@inodb
Copy link
Member Author

inodb commented Feb 21, 2024

@SAHU-01 Great digging! Thank you!

I see, so it's handled by the fronted atm, see e.g. https://frontend.cbioportal.org/news. But doesn't work when accessing thru the backend, https://cbioportal.org/news

I filed a PR for this, so it just passes it on to be handled at the frontend: #10658

inodb added a commit that referenced this issue Feb 21, 2024
* Fix News Page redirect

Fix #10632. Use frontend's existing redirect logic: cBioPortal/cbioportal-frontend#4342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants