Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots: should we list Clinical Attributes as a Profile Type to simplify the interface? #4432

Closed
4 tasks
jjgao opened this issue Jul 3, 2018 · 5 comments
Closed
4 tasks
Assignees
Milestone

Comments

@jjgao
Copy link
Member

jjgao commented Jul 3, 2018

We could

  • remove the two radio boxes to select Molecular Profile or Clinical Attribute
  • Move Profile Type to the first one
  • Add Clinical data into the Profile Type drop-down
  • Move Gene selection to the last one

Just a thought. Comments? @schultzn @tmazor @adamabeshouse

Current one:

image

@adamabeshouse
Copy link
Contributor

Makes perfect sense to me

@schultzn
Copy link
Contributor

schultzn commented Jul 5, 2018 via email

@jjgao
Copy link
Member Author

jjgao commented Jul 5, 2018

@schultzn yes.

@adamabeshouse could you give it a try? Maybe in a separate branch/pr in case we will revert it.

@pieterlukasse
Copy link
Member

@jjgao sounds good. One thought: maybe rename "Profile type" to something more generic like "Data type"? "Clinical data" is not something I would look for in a "Profile type" drop down.

@jjgao
Copy link
Member Author

jjgao commented Jul 6, 2018

@pieterlukasse I was thinking of that too, but should we also change Profile Name?

@jjgao jjgao changed the title Plots: should we list Clinical Attributes as a Profile Type to simply the interface? Plots: should we list Clinical Attributes as a Profile Type to simplify the interface? Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants