Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to indicate there are more samples to the right in oncoprint #5107

Closed
jjgao opened this issue Oct 25, 2018 · 10 comments
Closed

how to indicate there are more samples to the right in oncoprint #5107

jjgao opened this issue Oct 25, 2018 · 10 comments

Comments

@jjgao
Copy link
Member

jjgao commented Oct 25, 2018

Since there is no visibal horizontal scrollbar in chrome, it is not obvious that there are more samples to the right. How can we can tell the user there are more samples?

image

Showing the minimap would make it obvious but I guess it's too heavy.

Any thoughts? @adamabeshouse @alisman @cBioPortal/product

@adamabeshouse
Copy link
Contributor

I actually think showing minimap is probably the cleanest way to do it.. I think having an arrow or other indicator would just add clutter and more things to learn about the oncoprint. The minimap shows it in an obvious way without adding more

@schultzn
Copy link
Contributor

schultzn commented Oct 25, 2018 via email

@adamabeshouse
Copy link
Contributor

@schultzn theres a max height for oncoprint, and a vertical scrollbar shows up

@alisman
Copy link
Contributor

alisman commented Oct 25, 2018

@schultzn @jjgao scrollbar visibility is actually a system setting (at least on Mac)

@jjgao
Copy link
Member Author

jjgao commented Oct 25, 2018

@alisman @adamabeshouse I am wondering if this can solve it? https://stackoverflow.com/questions/7492062/css-overflow-scroll-always-show-vertical-scroll-bar

http://simurai.com/blog/2011/07/26/webkit-scrollbar

@adamabeshouse
Copy link
Contributor

I cant replicate the original error on my machine, can someone who can test it with the new PR: https://cbioportal-frontend-pr-1788.herokuapp.com/

@jjgao
Copy link
Member Author

jjgao commented Dec 4, 2018

scrollbar show up in the pr.

image

Is it possible to make it less predomiment, e.g. thinner and maybe lighter?

@adamabeshouse
Copy link
Contributor

lmao... yeah

@adamabeshouse
Copy link
Contributor

@jjgao update pushed

@jjgao
Copy link
Member Author

jjgao commented Dec 5, 2018

@adamabeshouse it looks still the same...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants