-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to indicate there are more samples to the right in oncoprint #5107
Comments
I actually think showing minimap is probably the cleanest way to do it.. I think having an arrow or other indicator would just add clutter and more things to learn about the oncoprint. The minimap shows it in an obvious way without adding more |
What if the OncoPrint has a lot of genes so that is pushed the mini map below the bottom of the screen?
Did we ever figure out why the scroll bar does not show up? Didn’t we determine that this was related to a Apple Cinema Display being plugged into a MacBook?
… On Oct 25, 2018, at 2:14 PM, Adam Abeshouse ***@***.***> wrote:
I actually think showing minimap is probably the cleanest way to do it.. I think having an arrow or other indicator would just add clutter and more things to learn about the oncoprint. The minimap shows it in an obvious way without adding more
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub <#5107 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALV34JMr59b9Mn5VuuUiN2ufpe6y3hauks5uof-RgaJpZM4X6xUP>.
|
@schultzn theres a max height for oncoprint, and a vertical scrollbar shows up |
@schultzn @jjgao scrollbar visibility is actually a system setting (at least on Mac) |
I cant replicate the original error on my machine, can someone who can test it with the new PR: https://cbioportal-frontend-pr-1788.herokuapp.com/ |
lmao... yeah |
@jjgao update pushed |
@adamabeshouse it looks still the same... |
Since there is no visibal horizontal scrollbar in chrome, it is not obvious that there are more samples to the right. How can we can tell the user there are more samples?
Showing the minimap would make it obvious but I guess it's too heavy.
Any thoughts? @adamabeshouse @alisman @cBioPortal/product
The text was updated successfully, but these errors were encountered: