Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mutations, CNA, SV gene charts to study view #6759

Closed
jjgao opened this issue Oct 31, 2019 · 18 comments · Fixed by cBioPortal/cbioportal-frontend#4794 or #10633
Closed

Adding mutations, CNA, SV gene charts to study view #6759

jjgao opened this issue Oct 31, 2019 · 18 comments · Fixed by cBioPortal/cbioportal-frontend#4794 or #10633

Comments

@jjgao
Copy link
Member

jjgao commented Oct 31, 2019

#6278 addresses pulling gene-level continuous data into study view. Let's also support categorical data, ie. mutations, discrete CNAs, and SVs. A pie chart will be displayed.

The slices for CNAs:

  • Amplification
  • Gain
  • Diploid
  • Shallow deletion
  • Deep deletion

The slices for mutations (option 1):

  • Mutated (the samples with one or more mutations in the gene)
  • Not mutated (the samples without mutations in the gene)
  • Not profiled (the samples that were not profiled)

The slices for mutations (option 2):

  • mutation types and driver vs vus as defined in oncoprint
  • Not mutated (the samples without mutations in the gene)
  • Not profiled (the samples that were not profiled)

The slices for mutations (option 3):

  • number of mutations in the gene
  • Not mutated (the samples without mutations in the gene)
  • Not profiled (the samples that were not profiled)

The slices for SVs (option 1):

  • Has SVs
  • No SVs
  • Not profiled

The slices for SVs (option 2):

  • SV types
  • No SVs
  • Not profiled

The slices for SVs (option 3) cBioPortal/icebox#454:

  • Different fusion partners (one partner per slice)
  • No partner (?)
  • No SVs
  • Not profiled

@cBioPortal/product

@Sjoerd-van-Hagen
Copy link

I like how this allows for easy construction of patients that are mutated for one gene and wildtype for another. You can now only do that via the group comparison view.

@Sjoerd-van-Hagen
Copy link

Regarding the options for the mutations, I think option 3 is not that useful. Option 1 and 2 could be combined in one pie chart but it is probably better to have separate ones. You could also separate option two in two pie charts, one for driver vs vus, the other one for the types. This will not allow you to do certain combinations though (driver of type X and vus of type Y), but you would get fewer slices, making it a bit easier to use maybe.

@tmazor
Copy link
Contributor

tmazor commented Nov 1, 2019

I actually think option 3 can be useful - it's a very specific question, but I can certainly imagine, for example, looking up a tumor suppressor to see how many samples have two mutations vs one mutation. I don't think there's any way to do this right now on the site.

In terms of options 1 & 2, we could combine those into one user-controlled plot. By default we plot as option 1, and then in the menu for that chart there can be options to also include mutations type and/or driver-vs-vus.

If we're adding driver-vs-vus functionality, then I think we also need to think about bringing over the driver definition controls from results view. Perhaps that global settings menu in results view can also exist in study view?

@schultzn
Copy link
Contributor

schultzn commented Nov 1, 2019 via email

@jjgao
Copy link
Member Author

jjgao commented Nov 4, 2019

Thanks, all great points! I think all three options can be combined into one chart and the user can switch between them.

@jjgao
Copy link
Member Author

jjgao commented Nov 4, 2019

@kalletlak It may not be strageforward to do driver-vs-vus for this yet. If that's the case we can leave it out for now. Once @zhx828 has the implementation for oncokb integration in the study view page, we can revisit that.

@stale
Copy link

stale bot commented Mar 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 10, 2020
@tmazor
Copy link
Contributor

tmazor commented Mar 11, 2020

I think we are still planning to do this?

@stale stale bot removed the stale label Mar 11, 2020
@stale
Copy link

stale bot commented Jun 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jjgao
Copy link
Member Author

jjgao commented Jul 24, 2020

@kalletlak: @Luke-Sikina is interested in working on this. Please give him some pointers. Thanks.

@kalletlak
Copy link
Member

@jjgao Sure. @Luke-Sikina thanks!

@jjgao jjgao added this to the Sprint 30 Y2020 milestone Jul 26, 2020
@jjgao jjgao changed the title pulling mutations and copy number Adding mutations and copy number to study view Jul 26, 2020
@jjgao jjgao added the Epic label Jul 26, 2020
@jjgao jjgao changed the title Adding mutations and copy number to study view Adding mutations and CNA gene charts to study view Jul 26, 2020
@inodb inodb modified the milestones: Sprint 30 Y2020, Sprint 32 Y2020 Aug 4, 2020
@inodb inodb removed this from the Sprint 32 Y2020 milestone Aug 18, 2020
@stale
Copy link

stale bot commented Nov 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 16, 2020
@tmazor tmazor removed the stale label Nov 17, 2020
@stale
Copy link

stale bot commented Feb 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 15, 2021
@tmazor tmazor removed the stale label Feb 15, 2021
@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 9, 2021
@tmazor tmazor removed the stale label Jun 9, 2021
@kalletlak kalletlak removed their assignment Aug 16, 2021
@stale
Copy link

stale bot commented Nov 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 29, 2021
@jjgao jjgao removed the stale label Dec 27, 2021
@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2022
@tmazor tmazor removed the stale label Apr 18, 2022
@tmazor
Copy link
Contributor

tmazor commented Jul 15, 2022

@cBioPortal/product this is the ticket we talked about this morning - let's see if we can work on it soon

@jjgao jjgao changed the title Adding mutations and CNA gene charts to study view Adding mutations, CNA, SV gene charts to study view Jul 18, 2022
@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants