-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding mutations, CNA, SV gene charts to study view #6759
Adding mutations, CNA, SV gene charts to study view #6759
Comments
I like how this allows for easy construction of patients that are mutated for one gene and wildtype for another. You can now only do that via the group comparison view. |
Regarding the options for the mutations, I think option 3 is not that useful. Option 1 and 2 could be combined in one pie chart but it is probably better to have separate ones. You could also separate option two in two pie charts, one for driver vs vus, the other one for the types. This will not allow you to do certain combinations though (driver of type X and vus of type Y), but you would get fewer slices, making it a bit easier to use maybe. |
I actually think option 3 can be useful - it's a very specific question, but I can certainly imagine, for example, looking up a tumor suppressor to see how many samples have two mutations vs one mutation. I don't think there's any way to do this right now on the site. In terms of options 1 & 2, we could combine those into one user-controlled plot. By default we plot as option 1, and then in the menu for that chart there can be options to also include mutations type and/or driver-vs-vus. If we're adding driver-vs-vus functionality, then I think we also need to think about bringing over the driver definition controls from results view. Perhaps that global settings menu in results view can also exist in study view? |
I agree with Tali on cBioPortal/cbioportal#3 - definitely very useful and we are looking at that kind of data more and more.
And 1 & 2 are both useful but could be combined...
… On Nov 1, 2019, at 9:59 AM, Tali Mazor ***@***.***> wrote:
I actually think option 3 can be useful - it's a very specific question, but I can certainly imagine, for example, looking up a tumor suppressor to see how many samples have two mutations vs one mutation. I don't think there's any way to do this right now on the site.
In terms of options 1 & 2, we could combine those into one user-controlled plot. By default we plot as option 1, and then in the menu for that chart there can be options to also include mutations type and/or driver-vs-vus.
If we're adding driver-vs-vus functionality, then I think we also need to think about bringing over the driver definition controls from results view. Perhaps that global settings menu in results view can also exist in study view?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub <#6759?email_source=notifications&email_token=AC2XPYH7ZDNVY7IXJCB5WT3QRQY4PA5CNFSM4JHNSUEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC27ZXQ#issuecomment-548797662>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2XPYBYZBMC2DM63L7ETO3QRQY4PANCNFSM4JHNSUEA>.
|
Thanks, all great points! I think all three options can be combined into one chart and the user can switch between them. |
@kalletlak It may not be strageforward to do driver-vs-vus for this yet. If that's the case we can leave it out for now. Once @zhx828 has the implementation for oncokb integration in the study view page, we can revisit that. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think we are still planning to do this? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@kalletlak: @Luke-Sikina is interested in working on this. Please give him some pointers. Thanks. |
@jjgao Sure. @Luke-Sikina thanks! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@cBioPortal/product this is the ticket we talked about this morning - let's see if we can work on it soon |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
#6278 addresses pulling gene-level continuous data into study view. Let's also support categorical data, ie. mutations, discrete CNAs, and SVs. A pie chart will be displayed.
The slices for CNAs:
The slices for mutations (option 1):
The slices for mutations (option 2):
The slices for mutations (option 3):
The slices for SVs (option 1):
The slices for SVs (option 2):
The slices for SVs (option 3) cBioPortal/icebox#454:
@cBioPortal/product
The text was updated successfully, but these errors were encountered: