oncoprint gradient shows up as solid block in pdf download

[adamabeshouse]

we've encountered this before...

#3119

@fedde-s @rnugraha can you help, what could possibly be the issue now?

[Sjoerd-van-Hagen]

Hi @adamabeshouse,

I remember we encountered this before, I think it was Riza who did, as Fedde does not remember. Fedde is also not working on cBioPortal at the moment. Hopefully @rnugraha remembers, but he just started his new job so I am not sure if he can look into this.

My vague recollection is, that when Riza encountered this, he reported it to the maintainers of the library that does the conversion. Apparently, they fixed it.

My suggestion to move forward in case Riza does not respond, is to try and go back to a version of the library that did work, and based on that report this to the maintainers.

[jjgao]

@adamabeshouse are we using the frontend sgv2pdf.js for oncoprint?

cBioPortal/cbioportal-frontend#2094

[adamabeshouse]

@jjgao yes, it is svg2pdf

[adamabeshouse]

@dippindots you're familiar with svg2pdf right? maybe you can take a look?

[dippindots]

@adamabeshouse Sure, I can take a look at this.

[dippindots]

Hey @adamabeshouse. I noticed that I have encountered this problem before, and fixed that #5886 (comment). I am wondering that if we changed the way to render the gradient in <rect> recently?

[adamabeshouse]

@dippindots I think the bug has maybe existed ever since then but we forgot about it. so it is just an issue with the svg2pdf library?

[adamabeshouse]

@dippindots looks like they merged your PR and released it :) but we never updated the version of svg2pdf in our codebase? i will make a PR now to update

[dippindots]

Thanks @adamabeshouse! I see, I will try to update the library, seems they changed something after the version we are using, may take some time to figure out.

[adamabeshouse]

yes, I encountered the same issue. looks like importing doesnt work the way it used to with jsdpf-yworks somehow