Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update svg2pdf to custom version (fix gradient shows up as solid block) #2911

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

dippindots
Copy link
Member

Fix cBioPortal/cbioportal#6765

Try to update svg2pdf to the latest version, but after updated to the latest version, the jspdf-yworks library throw error (not a constructor), didn't have luck to make it work.
Tried two different ways to solve the issue:

  1. Update svg2pdf.js to version from 1.3.3 to 1.3.4, but still use the older jspdf-yworks version. That fixed the fill gradient issue found in oncoprint, but introduced in other issue in study view (some charts will shrink to 1/4).
  2. Created a fork of svg2pdf.js library and cherry-pick the commit fixed the issue. Then use that as the package.
    Describe changes proposed in this pull request:
  • a fix gradient shows up as solid block
    image

@dippindots
Copy link
Member Author

@alisman @adamabeshouse @onursumer Could you comment on this one? I don't think the current solution is good enough, could I get some advices from you? Thanks!

@jjgao jjgao temporarily deployed to cbioportal-f-update-svg-x1oe9x December 5, 2019 17:11 Inactive
@adamabeshouse
Copy link
Contributor

@dippindots it seems fine to me, why dont you like this solution?

@dippindots
Copy link
Member Author

dippindots commented Dec 5, 2019

@adamabeshouse Personally I don't really like to use a specific commit of a package. But I am ok with it, should we at lease make a copy under cbioportal account (the repository using here is under my account)?

@adamabeshouse
Copy link
Contributor

@dippindots that sounds like a good idea. also if you feel better you can make a release and point package.json to that release tag instead of the commit hash

@alisman
Copy link
Collaborator

alisman commented Dec 6, 2019

@dippindots yeah, lets put the fork under cbioportal

@dippindots
Copy link
Member Author

@adamabeshouse @alisman Sure, thanks!

@dippindots
Copy link
Member Author

Thanks to @inodb helped me move the svg2pdf.js repo under cbiopotal. @alisman @adamabeshouse @onursumer I updated this pr, could you take a look again? thanks!

@jjgao jjgao had a problem deploying to cbioportal-f-update-svg-x1oe9x December 27, 2019 20:52 Failure
@jjgao jjgao temporarily deployed to cbioportal-f-update-svg-x1oe9x December 30, 2019 22:19 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-update-svg-wepbca December 31, 2019 16:58 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-update-svg-7c5e1b December 31, 2019 18:45 Inactive
@alisman alisman added the bug label Dec 31, 2019
@alisman alisman merged commit ff6cb51 into cBioPortal:master Dec 31, 2019
@dippindots dippindots deleted the update_svg2pdf branch December 31, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oncoprint gradient shows up as solid block in pdf download
4 participants