-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update svg2pdf to custom version (fix gradient shows up as solid block) #2911
Conversation
@alisman @adamabeshouse @onursumer Could you comment on this one? I don't think the current solution is good enough, could I get some advices from you? Thanks! |
@dippindots it seems fine to me, why dont you like this solution? |
@adamabeshouse Personally I don't really like to use a specific commit of a package. But I am ok with it, should we at lease make a copy under |
@dippindots that sounds like a good idea. also if you feel better you can make a release and point package.json to that release tag instead of the commit hash |
@dippindots yeah, lets put the fork under cbioportal |
@adamabeshouse @alisman Sure, thanks! |
accd615
to
98132e5
Compare
Thanks to @inodb helped me move the |
98132e5
to
005ddec
Compare
005ddec
to
d56d3f2
Compare
d56d3f2
to
cab2172
Compare
Fix cBioPortal/cbioportal#6765
Try to update
svg2pdf
to the latest version, but after updated to the latest version, thejspdf-yworks
library throw error (not a constructor), didn't have luck to make it work.Tried two different ways to solve the issue:
svg2pdf.js
to version from1.3.3
to1.3.4
, but still use the olderjspdf-yworks
version. That fixed the fill gradient issue found in oncoprint, but introduced in other issue in study view (some charts will shrink to 1/4).svg2pdf.js
library and cherry-pick the commit fixed the issue. Then use that as the package.Describe changes proposed in this pull request: