Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on study view move selections to the top of the table #6896

Closed
inodb opened this issue Dec 9, 2019 · 5 comments · Fixed by cBioPortal/cbioportal-frontend#2980
Closed

on study view move selections to the top of the table #6896

inodb opened this issue Dec 9, 2019 · 5 comments · Fixed by cBioPortal/cbioportal-frontend#2980

Comments

@inodb
Copy link
Member

inodb commented Dec 9, 2019

It sometimes hard to find your selection in the various tables on the study view

@jjgao
Copy link
Member

jjgao commented Dec 13, 2019

For example, in this one, the four selected genes should be listed first. Ideally we should alternate colors between different selections, e.g. (SMARCA4) one color (e.g. gray) and (TP53, PIK3CA, KMT2C) (e.g. light gray)

image

@kalletlak
Copy link
Member

@inodb its because of some of the unselected rows have higher frequency. Here is an example

Screen Shot 2020-01-10 at 1 28 01 PM

@jjgao there will be another issue doing alternate colors between different selections, genes within the selection are not always grouped together(as seen in the above image)

@jjgao
Copy link
Member

jjgao commented Jan 10, 2020

@kalletlak for the selected genes, is it possible to always add them first and follow the same order as in the filters (ideally the same order as user adds)?

@kalletlak
Copy link
Member

@jjgao in this case we may have to exclude them from sorting. is the ok?

@jjgao
Copy link
Member

jjgao commented Jan 10, 2020

@kalletlak that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants