Study View: Always show selected genes on top and alternate selected rows color #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjgao
approved these changes
Jan 15, 2020
alisman
reviewed
Jan 15, 2020
alisman
reviewed
Jan 15, 2020
| if (index === -1) { | ||
| return null; | ||
| } | ||
| return index % 2 === 0 ? styles.highlightedEvenRow : styles.highlightedOddRow; |
There was a problem hiding this comment.
you don't need to do this with code, you can do it with CSS, for eample in simpleTable/styles.scss we do:
tbody>tr:nth-of-type(odd).highlighted {
background-color: #9FAFD1 !important;
}
tbody>tr:nth-of-type(even) { // solid background - hard coded hack, react-bootstrap .table-striped makes ODD # rows grey
background-color: rgb(255,255,255);
}
tbody>tr:nth-of-type(even).highlighted {
background-color: #B0BED9;
}
I think we should do it like that because it's more efficient and simpler in the code.
There was a problem hiding this comment.
Here the color is not alternating. alternating color for each selection (there can be more than one row in each selection)
There was a problem hiding this comment.
is there a chance of many selected rows? if so then this process will be slow - it would be faster to have a map that takes uniquekey to the first index of filter in which it appears, so that you can check this in constant time
adamabeshouse
requested changes
Jan 15, 2020
kalletlak
force-pushed
the
fix-6896
branch
2 times, most recently
from
3adbda1
to
ea09d84
Compare
adamabeshouse
approved these changes
Jan 16, 2020
kalletlak
force-pushed
the
fix-6896
branch
2 times, most recently
from
216cf2d
to
107dca1
Compare
alisman
reviewed
Jan 22, 2020
alisman
approved these changes
Jan 22, 2020
kalletlak
force-pushed
the
fix-6896
branch
2 times, most recently
from
84fa0d8
to
d4b4ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#6896
Fixes