Draft: Genomic data counts #10293
Draft: Genomic data counts #10293
Conversation
|
|
||
| public class CopyNumberCountFilter { | ||
|
|
||
| private String molecularProfileId; |
There was a problem hiding this comment.
should support multi profile, use profileType instead of molecularProfileId
There was a problem hiding this comment.
Looks like you are not using this class anymore. could you remove it?
web/src/main/java/org/cbioportal/web/parameter/CopyNumberCountFilter.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class CopyNumberCountFilter { | ||
|
|
||
| private String molecularProfileId; |
There was a problem hiding this comment.
Looks like you are not using this class anymore. could you remove it?
| List<String> hugoGeneSymbols, | ||
| AlterationFilter alterationFilter) throws StudyNotFoundException { | ||
| List<MolecularProfileCaseIdentifier> caseIdentifiers = | ||
| molecularProfileService.getFirstDiscreteCNAProfileCaseIdentifiers(studyIds, sampleIds); |
There was a problem hiding this comment.
Discrete profile comes from request (GenomicDataFilter). Not choosing the first one.
Ref: look into how data is fetched in/genomic-data-bin-counts/fetch
| studyIds, | ||
| sampleIds, | ||
| gdFilters.stream().map(GenomicDataFilter::getHugoGeneSymbol).collect(Collectors.toList()), | ||
| studyViewFilter.getAlterationFilter()); |
There was a problem hiding this comment.
studyViewFilter is used in filtering data. This shouldn't be used here.
There was a problem hiding this comment.
What is the alterationFilter to be used? Do you mean to create a brand new alterationFilter in StudyViewService?
|
Kudos, SonarCloud Quality Gate passed! |
Implement backend changes in issue #10257