Molecular-profile-counts service implementation #10840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
changed the title
alisman
force-pushed
the
molecularProfile
branch
from
8c6ad34
to
1eb3cfc
Compare
alisman
changed the title
alisman
commented
Jun 19, 2024
src/main/java/org/cbioportal/persistence/StudyViewRepository.java
Outdated
Show resolved
Hide resolved
haynescd
requested changes
Jun 20, 2024
src/main/java/org/cbioportal/persistence/StudyViewRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cbioportal/persistence/mybatisclickhouse/StudyViewMapper.java
Outdated
Show resolved
Hide resolved
Comment on lines
+22
to
+26
| SELECT sample_mv.sample_unique_id | ||
| FROM sample_profile | ||
| JOIN genetic_profile gp ON sample_profile.genetic_profile_id = gp.genetic_profile_id | ||
| JOIN cancer_study cs ON gp.cancer_study_id = cs.cancer_study_id | ||
| JOIN sample_mv on sample_profile.sample_id = sample_mv.internal_id |
There was a problem hiding this comment.
The genomic_event_derived table has this info without the need of a join.
Comment on lines
+28
to
+31
| sample_mv.cancer_study_identifier IN | ||
| <foreach item="studyId" collection="studyViewFilter.studyIds" open="(" separator="," close=")"> | ||
| #{studyId} | ||
| </foreach> |
There was a problem hiding this comment.
Do you need this filter? Since the filter for studyIds are above?
There was a problem hiding this comment.
@haynescd i m erged this PR but made follow up issues for this and the above comment
alisman
force-pushed
the
molecularProfile
branch
from
21bb5e4
to
9284c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.