Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added chromosome query parameter for copy number segments endpoint #5321

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

onursumer
Copy link
Member

Checks

  • Runs on Heroku.
  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Google Style Guide.
  • If this is a feature, the PR is to rc. If this is a bug fix, the PR is to master.

@ersinciftci ersinciftci merged commit 99a3afc into cBioPortal:rc Nov 26, 2018
@onursumer onursumer deleted the cn-segments-chromosome branch December 7, 2018 23:09
@inodb inodb mentioned this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants