fix: normalise path separators on Windows to fix sub-package tags #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git cli and the go os library return representations of the same path using different path separators, so the comparison used here returned false, and the absolute path of the repo was set as the default for the pattern arg. e.g.: > git rev-parse --show-toplevel C:/Users/Doug/Code/myrepo os.getWd() C:\\Users\\Doug\\Code\\myrepo Using filepath.Clean() on both paths before using them normalises the slashes to a single "\"
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git cli and the go os library return representations of the same path using different path separators, so the comparison used here returned false, and the absolute path of the repo was set as the default for the pattern arg.
e.g.:
Using filepath.Clean() on both paths before using them normalises the slashes to a single
\Fixes #164