Leave pms #89
Merged
Leave pms #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getter refers to the CabalDetails instance which holds the settings for the cabal to determine if the private message channel should be considered joined or not. This has the side affect of requiring the CabalDetails when initializing the PMChannelDetails, which involves changing the constructor signature.
|
released as [email protected] @dchiquito :~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supercedes & closes #87
thanks for the PR @dchiquito! pushing up this fork of yer PR which has some additional improvements to make sure the UX stays the same for people upgrading clients :>