Archive channels #305
Archive channels #305
Conversation
app/actions.js
Outdated
| // Disable a few slash commands for now | ||
| const removedCommands = ['add', 'channels', 'clear', 'ids', 'names', 'new', 'qr', 'whoami', 'whois'] | ||
| removedCommands.forEach((command) => { | ||
| client.removeCommand(command) | ||
| }) | ||
| // const removedCommands = ['add', 'channels', 'clear', 'ids', 'names', 'new', 'qr', 'whoami', 'whois'] | ||
| // removedCommands.forEach((command) => { | ||
| // client.removeCommand(command) | ||
| // }) |
There was a problem hiding this comment.
should we just remove these lines?
There was a problem hiding this comment.
maybe?! this was among the few things that didnt work with the latest cabal-client. i didnt spend any time trying to understand why though.
There was a problem hiding this comment.
ah! maybe that's my fault when i refactored the commands stuff! let's create an issue and link it at the commented out code block?
| @@ -343,7 +381,7 @@ export const viewChannel = ({ addr, channel, skipScreenHistory }) => (dispatch, | |||
| client.focusChannel(channel) | |||
| client.markChannelRead(channel) | |||
| } else { | |||
| dispatch(joinChannel({ addr, channel })) | |||
| // dispatch(joinChannel({ addr, channel })) | |||
There was a problem hiding this comment.
| // dispatch(joinChannel({ addr, channel })) |
There was a problem hiding this comment.
This is the main issue that came up with the cabal-client update which threw the app into a loop. It seems that joinChannel isnt really needed here though as things seem to work as expected without it. My guess is other bugs in Desktop were hiding the real problem.
There was a problem hiding this comment.
maybe we can encode this in a comment above the line? would be nice to keep the context intact, in case there's a bug in cabal-client somehow :)
|
@nikolaiwarner nice! 🍰 i think there is more margin than needed between the leave channel / archive channel buttons in the first screenshot, do you agree with making it a bit tighter? |
Co-authored-by: Alexander Cobleigh <[email protected]>
thanks! yeah, i also think i should swap leave and archive. since one may leave more often than archive. i'm in a weird place with this codebase really. i'm quite ready to start from scratch... approaching this project with what we've learned over three years, meets our current goals, and does things in the most modern and efficient way. that of course would be the project that builds the desktop client and the interface for browsers. so i guess what im saying is that this might be the last feature until cabal-desktop-next |
Co-authored-by: Alexander Cobleigh <[email protected]>
i hear ya :)
💯 i think it's at the perfect stopping off point for new features as well, considering the timing of starting on cabal-web. i think the exception would be tiny bug fixes for people using the clients in the interim? i'm mainly thinking of finding a fix for messages showing up twice. that's easy for me to say tho, considering i mostly pull my weight in the other repos 😅 anyway, nice!!! it would be cool if we could add the context you wrote in the comments above inside the source as code comments, other than that 🚢 📦 it! 🖤 |
|
I'll clean things up with your suggestions then make a build that i'll share privately with some folx. I'd like to test things out real good before merging this and releasing. |
heck yeah! i'll give it a spin on my win desktop some time this week then :) |
This also bumps Cabal Desktop to use the latest cabal-client and does just a little code cleanup.