move process implementations to separate modules #668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord this is a proposal implementation for splitting up the process-managers into separate modules.
I must say that this became a bit bigger than I initially anticipated, but it seemed like the refactorings were still useful and backwards-compatible.
There are a few todo's in here to propose further changes, but first wanted to get feedback on this proposal as-is.
While working on this I also felt it might be a good idea to move generating the Procfile and env-file into a
pkgs.formats.procfile
andpkgs.formats.envfile
. That way these implementations can be reused, but do not need to reside as options (process-compose doesn't use them for instance, as do a number of other non-procfile-based process managers). Not really needed to worry about right now though.