Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddyfile: Make NewTestDispenser accessible for plugin authors #3439

Merged
merged 1 commit into from
May 26, 2020

Conversation

francislavoie
Copy link
Member

See discussion in #3402, we've had a couple suggestions to move this out of the _test file to make it usable for plugin authors in their own tests.

@francislavoie francislavoie requested a review from mholt May 23, 2020 13:18
@francislavoie francislavoie added this to the 2.1 milestone May 23, 2020
@francislavoie francislavoie linked an issue May 23, 2020 that may be closed by this pull request
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suppose this'll be helpful then.

@mholt mholt merged commit ffc125d into caddyserver:master May 26, 2020
@francislavoie francislavoie deleted the move-newtestdispenser branch May 26, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2: Writing unit tests for Caddyfile parsing logic
3 participants