reverseproxy: Support 1xx status codes (HTTP early hints) #4882
Conversation
francislavoie
changed the title
There was a problem hiding this comment.
I have not tested this myself, but the change is sound IMO. I am excited to merge this so that people can start testing it more easily (they will need Go 1.19 obviously).
We just tagged a release today so this should give a fair amount of time for bleeding-edge users to try it out before the next release.
Thank you for the excellent help/support and implementation, @dunglas !
mholt
changed the title
mholt
changed the title
|
This should be ready now that Caddy supports Go 1.19 (#4925). |
| func init() { | ||
| supports1xx = !regexp.MustCompile(`^go1\.1(?:7|8)\.`).Match([]byte(runtime.Version())) |
There was a problem hiding this comment.
Could this be simplified to just match Go 1.18, since that's our minimum now?
|
Cool. I was waiting for a sponsor to test this out in their company, but they seem to have been delayed somewhat. I'm good with merging this whenever. I haven't had a chance to do my own testing of this but I assume it works given the history here. |
|
hey Matt, The setup works perfectly. good to go. Thanks for the making this quick. Took us a while to implement the necessary changes like Caching html link tags etc to fully utilise this new header. Thanks @dunglas I will share the results soon. |
|
That's awesome!! Thanks for testing it! |
Fixes #4860.
Backport of golang/go#53164