-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enabling a few more linters #5961
chore: enabling a few more linters #5961
Commits on Jan 2, 2024
-
Checks that all code identifiers does not have non-ASCII symbols in the name. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d8ef1c0 - Browse repository at this point
Copy the full SHA d8ef1c0View commit details -
Checks for dangerous unicode character sequences. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 722fa94 - Browse repository at this point
Copy the full SHA 722fa94View commit details -
Check for pass []any as any in variadic func(...any). Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2e3019 - Browse repository at this point
Copy the full SHA f2e3019View commit details -
Checks assignments with too many blank identifiers (e.g. x, , , _, := f()). Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cf20b78 - Browse repository at this point
Copy the full SHA cf20b78View commit details -
Adding containedctx and contextcheck to implicitly disabled
Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79f24c0 - Browse repository at this point
Copy the full SHA 79f24c0View commit details -
Adding dupl as a linter (not for log filters)
for code clone detection. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for de5f903 - Browse repository at this point
Copy the full SHA de5f903View commit details -
Check declaration order and count of types, constants, variables and functions. Also adding cyclop to the list of implicitly disabled linters. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c34553 - Browse repository at this point
Copy the full SHA 1c34553View commit details -
Checks for duplicate words in the source code. Also fixed duplicate words in 3 files. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 483800a - Browse repository at this point
Copy the full SHA 483800aView commit details -
Adding durationcheck as a linter.
Check for two durations multiplied together. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6536bc2 - Browse repository at this point
Copy the full SHA 6536bc2View commit details -
Adding errchkjson to implicitly disabled linters
Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 75912d6 - Browse repository at this point
Copy the full SHA 75912d6View commit details -
Adding exhaustive as a linter.
Check exhaustiveness of enum switch statements. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c516fa - Browse repository at this point
Copy the full SHA 2c516faView commit details -
Adding exportloopref as a linter.
Checks for pointers to enclosing loop variables. Also adding exhaustruct to the list of implicitly disabled linters. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 60246e7 - Browse repository at this point
Copy the full SHA 60246e7View commit details -
Adding whitespace as a linter.
Whitespace is a linter that checks for unnecessary newlines at the start and end of functions, if, for, etc. Patching the few issues it found too. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cac89c5 - Browse repository at this point
Copy the full SHA cac89c5View commit details -
Adding zerologlint as a linter.
Detects the wrong usage of zerolog that a user forgets to dispatch with Send or Msg. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6070fa4 - Browse repository at this point
Copy the full SHA 6070fa4View commit details -
Adding wastedassign as a linter.
Finds wasted assignment statements. Adding wrapcheck to the list of implicitly disabled linters. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 915354f - Browse repository at this point
Copy the full SHA 915354fView commit details -
Checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error. Also fixing one case in reverse proxy and exporting the error to allow error matching against it. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 714476c - Browse repository at this point
Copy the full SHA 714476cView commit details -
Updating the list of implicitly disabled linters.
To have all the current linters that aren't archived or deprecated as per golangci-lint.run/usage/linters/. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for be506d5 - Browse repository at this point
Copy the full SHA be506d5View commit details -
Fix exhaustive linter on windows on svc.Cmd
Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5290384 - Browse repository at this point
Copy the full SHA 5290384View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f28efb5 - Browse repository at this point
Copy the full SHA f28efb5View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2663edd - Browse repository at this point
Copy the full SHA 2663eddView commit details -
Ensure consistent code style when using log/slog. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ca35e7e - Browse repository at this point
Copy the full SHA ca35e7eView commit details -
Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 68e025f - Browse repository at this point
Copy the full SHA 68e025fView commit details -
Check import statements are formatted according to the 'goimport' command. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f8e2ddd - Browse repository at this point
Copy the full SHA f8e2dddView commit details -
Enforces consistent import aliases. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99c7ae0 - Browse repository at this point
Copy the full SHA 99c7ae0View commit details -
Tparallel detects inappropriate usage of t.Parallel() method in Go test codes. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c6f49f8 - Browse repository at this point
Copy the full SHA c6f49f8View commit details -
Adding testifylint as a linter.
Checks proper usage of github.com/stretchr/testify. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 00e5cdc - Browse repository at this point
Copy the full SHA 00e5cdcView commit details -
Adding testableexamples as a linter.
This linter checks if examples are testable (have an expected output). Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e8dd764 - Browse repository at this point
Copy the full SHA e8dd764View commit details -
Tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a2182d9 - Browse repository at this point
Copy the full SHA a2182d9View commit details -
Adding sqlclosecheck as a linter.
Checks that sql.Rows, sql.Stmt, sqlx.NamedStmt, pgx.Query are closed. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for df496d7 - Browse repository at this point
Copy the full SHA df496d7View commit details -
Adding promlinter as a linter.
Check Prometheus metrics naming via promlint. Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 752e727 - Browse repository at this point
Copy the full SHA 752e727View commit details -
Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dada8fd - Browse repository at this point
Copy the full SHA dada8fdView commit details -
Use latest golangci-lint version in GHA.
Signed-off-by: Yolan Romailler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ebb0944 - Browse repository at this point
Copy the full SHA ebb0944View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe73311 - Browse repository at this point
Copy the full SHA fe73311View commit details