Skip to content

Commit

Permalink
zerossl: Make CNAME target absolute (fix #304)
Browse files Browse the repository at this point in the history
  • Loading branch information
mholt committed Aug 2, 2024
1 parent 1ff1ad8 commit 16c9db1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion acmeclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (iss *ACMEIssuer) newACMEClientWithAccount(ctx context.Context, useTestCA,
}

// we try loading the account from storage before a potential
// lock, and 0after obtaining the lock as well, to ensure we don't
// lock, and after obtaining the lock as well, to ensure we don't
// repeat work done by another instance or goroutine
getAccount := func() (acme.Account, error) {
// look up or create the ACME account
Expand Down
2 changes: 1 addition & 1 deletion zerosslissuer.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func (iss *ZeroSSLIssuer) Issue(ctx context.Context, csr *x509.CertificateReques
// create the CNAME record(s)
records := make(map[string]zoneRecord, len(cert.Validation.OtherMethods))
for name, verifyInfo := range cert.Validation.OtherMethods {
zr, err := iss.CNAMEValidation.createRecord(ctx, verifyInfo.CnameValidationP1, "CNAME", verifyInfo.CnameValidationP2)
zr, err := iss.CNAMEValidation.createRecord(ctx, verifyInfo.CnameValidationP1, "CNAME", verifyInfo.CnameValidationP2+".") // see issue #304
if err != nil {
return nil, fmt.Errorf("creating CNAME record: %v", err)
}
Expand Down

0 comments on commit 16c9db1

Please sign in to comment.