Fix/no workflow found #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epricated. see issue #192
meiliang86
approved these changes
Oct 23, 2020
client/main.js
Outdated
| @@ -137,8 +137,8 @@ const routeOpts = { | |||
| component: WorkflowTabs, | |||
| props: ({ params }) => ({ | |||
| domain: params.domain, | |||
| runId: params.runId, | |||
| workflowId: params.workflowId, | |||
| runId: getEscapedForwardSlash(params.runId), | |||
There was a problem hiding this comment.
runID is generated by cadence and is always uuid
There was a problem hiding this comment.
I will remove it if thats the case. Thanks!
…teed to be a UUID
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error caused by router not escaping forward slashes correctly.
When making API request it would try to double escape the forward slash using encodeURIComponent function which would cause the API to return "workflow not found" error.
This will now enforce at the router level that forward slashes are now correctly escaped ( / => %2F ).
Closes #207