Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task parser does not support symbols or numbers in task names #37

Closed
agc93 opened this issue Sep 29, 2016 · 0 comments
Closed

Task parser does not support symbols or numbers in task names #37

agc93 opened this issue Sep 29, 2016 · 0 comments
Assignees
@agc93
Labels
Bug
Milestone
v0.2.0

Comments

@agc93
Copy link
Member

agc93 commented Sep 29, 2016

The pattern used to identify tasks only recognises names composed entirely of letters (i.e. no numbers, symbols or whitespace).

Since these are all valid, the task parser should allow them.
@agc93 agc93 self-assigned this Sep 29, 2016
@agc93 agc93 added this to the v0.2.0 milestone Sep 29, 2016
@agc93 agc93 added the Bug label Sep 29, 2016
agc93 added a commit to agc93/cake-vs that referenced this issue Sep 30, 2016
@agc93
Update task match pattern to support symbols and numbers in task name…
9dd6615 
…s (to fix cake-build#37)
@agc93 agc93 mentioned this issue Sep 30, 2016
Merged
@gep13 gep13 closed this as completed in #38 Sep 30, 2016
gep13 added a commit that referenced this issue Sep 30, 2016
@gep13
Merge pull request #38 from agc93/feature/gh-37
870ee7d 
GH37: Support numbers and symbols in task names
@gep13 gep13 mentioned this issue Oct 17, 2016
Closed
@matkoch matkoch mentioned this issue Dec 11, 2016
Closed
gep13 added a commit that referenced this issue Aug 22, 2017
@gep13
Merge branch 'release/0.2.0'
0f11ab7 
* release/0.2.0: (24 commits)
  (build) Corrected failing build in 15.3 Visual Studio
  (GH-76) Updated to Cake 0.21.1
  (GH-18) Tabs to Spaces
  (maint) Update to https
  Add support for drag-and-drop with cake and dll files
  Re-target to .NET Framework 4.6 and update NuGet dependencies
  Update Cake dependencies/templates to 0.19.4
  Adds Visual Studio 2017 support
  added params key word
  (GH-64) Update Cake to 0.17.0/1
  Add support for Cake-specific language/IDE settings
  Add MagicChunks-powered version transform
  Remove diagnostic logging, fix manifest versioning
  Upload as single stream, not multipart
  Fix compilation error and rookie mistake
  Additional logging for MyGet upload client
  task-runner: Rework regex to allow whitespace
  Additional build scripts for CI builds/packages
  Added support for "smart" indentation in Cake files. Indents are added on method body open, otherwise last offset used.
  Update task match pattern to support symbols and numbers in task names (to fix #37)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agc93 agc93

Labels
Bug
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@agc93