Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new VS2019 SDKs and APIs. Migrate to an AsyncPackage load. #103

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

agc93
Copy link
Member

@agc93 agc93 commented Mar 19, 2019

This transitions to AsyncPackage (going to be required in future), updates references to support VSSDK 16.x and updated template format. Resolves #101.

I have tested against VS2019 Preview 4.3 and it looks like this is all that's needed for VS2019 support. Resolves #98.

@agc93 agc93 added this to the 0.3.0 milestone Mar 19, 2019
@agc93
Copy link
Member Author

agc93 commented Mar 20, 2019

@cake-build/cake-team Anyone else got the VS2019 Preview installed? Would be good to get someone to try this one out...

@agc93
Copy link
Member Author

agc93 commented Mar 20, 2019

Alright we just outsourced our testing to @david-driscoll and it looks like this is compatible with VS2019 Preview. LGTM and @gep13 agrees.

:shipit: time

@agc93 agc93 merged commit 623d7bf into cake-build:develop Mar 20, 2019
@agc93 agc93 deleted the feature/gh-101 branch March 20, 2019 20:17
@p10tyr
Copy link

p10tyr commented Mar 6, 2020

Do you know when the extension will be available on the official market place? Came here to find people suggesting to use myget and everything is working fine in VS2019 using that source.

So it looks like Version="[14.0,17.0)" /> is set to already support 2019 - Does it just require a build an publish to market place?

<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[14.0,17.0)" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update extension to use new VSSDK APIs Make available for VS 2019
3 participants