Skip to content

Commit

Permalink
Bump netcoreapp target frameworks to lts
Browse files Browse the repository at this point in the history
  • Loading branch information
gitfool authored and devlead committed Oct 9, 2021
1 parent 2c736de commit 2a1f7d0
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions build.cake
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Task("Run-Unit-Tests")
() => GetFiles("./src/**/*.Tests.csproj"),
(parameters, project, context) =>
{
foreach(var framework in new[] { "netcoreapp2.0", "netcoreapp3.0", "net461", "net5.0", "net6.0" })
foreach(var framework in new[] { "netcoreapp2.1", "netcoreapp3.1", "net461", "net5.0", "net6.0" })
{
FilePath testResultsPath = MakeAbsolute(parameters.Paths.Directories.TestResults
.CombineWithFilePath($"{project.GetFilenameWithoutExtension()}_{framework}_TestResults.xml"));
Expand Down Expand Up @@ -182,7 +182,7 @@ Task("Copy-Files")
// .NET Core
DotNetCorePublish("./src/Cake/Cake.csproj", new DotNetCorePublishSettings
{
Framework = "netcoreapp2.0",
Framework = "netcoreapp2.1",
NoRestore = true,
Configuration = parameters.Configuration,
OutputDirectory = parameters.Paths.Directories.ArtifactsBinNetCore,
Expand Down Expand Up @@ -655,7 +655,7 @@ Task("Run-Integration-Tests")
.DoesForEach<BuildParameters, FilePath>(
parameters => new[] {
GetFiles($"{parameters.Paths.Directories.IntegrationTestsBinTool.FullPath}/**/netcoreapp2.1/**/Cake.dll").Single(),
GetFiles($"{parameters.Paths.Directories.IntegrationTestsBinTool.FullPath}/**/netcoreapp3.0/**/Cake.dll").Single(),
GetFiles($"{parameters.Paths.Directories.IntegrationTestsBinTool.FullPath}/**/netcoreapp3.1/**/Cake.dll").Single(),
GetFiles($"{parameters.Paths.Directories.IntegrationTestsBinTool.FullPath}/**/net5.0/**/Cake.dll").Single(),
GetFiles($"{parameters.Paths.Directories.IntegrationTestsBinTool.FullPath}/**/net6.0/**/Cake.dll").Single(),
parameters.Paths.Directories.IntegrationTestsBinFullFx.CombineWithFilePath("Cake.exe"),
Expand Down
2 changes: 1 addition & 1 deletion build/paths.cake
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class BuildPaths
var artifactsDir = (DirectoryPath)(context.Directory("./artifacts") + context.Directory("v" + semVersion));
var artifactsBinDir = artifactsDir.Combine("bin");
var artifactsBinFullFx = artifactsBinDir.Combine("net461");
var artifactsBinNetCore = artifactsBinDir.Combine("netcoreapp2.0");
var artifactsBinNetCore = artifactsBinDir.Combine("netcoreapp2.1");
var testResultsDir = artifactsDir.Combine("test-results");
var nugetRoot = artifactsDir.Combine("nuget");

Expand Down
8 changes: 4 additions & 4 deletions src/Cake.Common/Tools/DotNetCore/DotNetCoreAliases.cs
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ public static void DotNetCoreBuild(this ICakeContext context, string project)
/// <code>
/// var settings = new DotNetCoreBuildSettings
/// {
/// Framework = "netcoreapp2.0",
/// Framework = "netcoreapp3.1",
/// Configuration = "Debug",
/// OutputDirectory = "./artifacts/"
/// };
Expand Down Expand Up @@ -392,7 +392,7 @@ public static void DotNetCoreRun(this ICakeContext context, string project, Proc
/// <code>
/// var settings = new DotNetCoreRunSettings
/// {
/// Framework = "netcoreapp2.0",
/// Framework = "netcoreapp3.1",
/// Configuration = "Release"
/// };
///
Expand Down Expand Up @@ -471,7 +471,7 @@ public static void DotNetCorePublish(this ICakeContext context, string project)
/// <code>
/// var settings = new DotNetCorePublishSettings
/// {
/// Framework = "netcoreapp2.0",
/// Framework = "netcoreapp3.1",
/// Configuration = "Release",
/// OutputDirectory = "./artifacts/"
/// };
Expand Down Expand Up @@ -693,7 +693,7 @@ public static void DotNetCoreClean(this ICakeContext context, string project)
/// <code>
/// var settings = new DotNetCoreCleanSettings
/// {
/// Framework = "netcoreapp2.0",
/// Framework = "netcoreapp3.1",
/// Configuration = "Debug",
/// OutputDirectory = "./artifacts/"
/// };
Expand Down
4 changes: 2 additions & 2 deletions src/Cake/Cake.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
<AssemblyName>Cake</AssemblyName>
<OutputType>Exe</OutputType>
<PlatformTarget>AnyCpu</PlatformTarget>
<TargetFrameworks>netcoreapp2.1;netcoreapp3.0;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks>netcoreapp2.1;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
</PropertyGroup>

<PropertyGroup Condition=" '$(PackAsTool)' != 'true'">
<TargetFrameworks>net461;netcoreapp2.0;$(TargetFrameworks);</TargetFrameworks>
<TargetFrameworks>net461;$(TargetFrameworks);</TargetFrameworks>
</PropertyGroup>

<Import Project="$(MSBuildThisFileDirectory)..\Shared.msbuild" />
Expand Down
2 changes: 1 addition & 1 deletion src/Shared.msbuild
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</PropertyGroup>

<!-- Define .NET Core constants -->
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'netcoreapp2.0' OR '$(TargetFramework)' == 'netcoreapp2.1' OR '$(TargetFramework)' == 'netcoreapp3.0' OR '$(TargetFramework)' == 'net5.0' OR '$(TargetFramework)' == 'net6.0' ">
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'netcoreapp2.1' OR '$(TargetFramework)' == 'netcoreapp3.1' OR '$(TargetFramework)' == 'net5.0' OR '$(TargetFramework)' == 'net6.0' ">
<NetStandardImplicitPackageVersion>2.0.0</NetStandardImplicitPackageVersion>
<DefineConstants>$(DefineConstants);NETCORE</DefineConstants>
<DebugType>portable</DebugType>
Expand Down

0 comments on commit 2a1f7d0

Please sign in to comment.