Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DebuggerStepThroughAttribute to generated code #2820

Closed
gep13 opened this issue Jun 29, 2020 · 3 comments · Fixed by #2821
Closed

Add DebuggerStepThroughAttribute to generated code #2820

gep13 opened this issue Jun 29, 2020 · 3 comments · Fixed by #2821
Assignees
@bjorkstromm
Labels
Improvement
Milestone
v1.0.0

Comments

@gep13
Copy link
Member

gep13 commented Jun 29, 2020

This will make the debugging experience in IDE's much better, when using (for example) addins that have been run with SourceLink.

Currently, you have to step into the code twice to make it work. This is due to the generated code;

https://github.com/OmniSharp/omnisharp-roslyn/blob/master/tests/OmniSharp.Cake.Tests/TestAssets/single.cake.g.txt#L7722

First step into takes can't find any symbols to step to, the second takes you to the actual method.
@gep13 gep13 added this to the v1.0.0 milestone Jun 29, 2020
@gep13
Copy link
Member Author

gep13 commented Jun 29, 2020

Affected area of code:

https://github.com/cake-build/cake/blob/develop/src/Cake.Core/Scripting/CodeGen/MethodAliasGenerator.cs

@gep13
Copy link
Member Author

gep13 commented Jun 29, 2020

Also this area of code:

https://github.com/cake-build/cake/blob/develop/src/Cake.Core/Scripting/CodeGen/PropertyAliasGenerator.cs

bjorkstromm added a commit to bjorkstromm/cake that referenced this issue Jun 29, 2020
@bjorkstromm
(cake-buildGH-2820) Adds DebuggerStepThroughAttribute to generated code.
3944535 
- Fixes cake-build#2820
@bjorkstromm bjorkstromm mentioned this issue Jun 29, 2020
Merged
bjorkstromm added a commit to bjorkstromm/cake that referenced this issue Jun 30, 2020
@bjorkstromm
(cake-buildGH-2820) Adds DebuggerStepThroughAttribute to generated code.
9b25cea 
- Fixes cake-build#2820
bjorkstromm added a commit to bjorkstromm/cake that referenced this issue Jun 30, 2020
@bjorkstromm
(cake-buildGH-2820) Adds DebuggerStepThroughAttribute to generated code.
65b1b71 
- Fixes cake-build#2820
devlead added a commit that referenced this issue Jul 1, 2020
@devlead
Merge pull request #2821 from mholo65/feature/GH-2820
6f8a146 
(GH-2820) Adds DebuggerStepThroughAttribute to generated code.
@devlead devlead mentioned this issue Nov 5, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorkstromm bjorkstromm

Labels
Improvement
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

GH2820: Adds DebuggerStepThroughAttribute to generated code. bjorkstromm/cake
3 participants
@gep13 @bjorkstromm @cake-build-bot