Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore tool exit code #2825

Closed
flcdrg opened this issue Jul 8, 2020 · 3 comments
Closed

Add option to ignore tool exit code #2825

flcdrg opened this issue Jul 8, 2020 · 3 comments
Milestone

Comments

@flcdrg
Copy link
Contributor

flcdrg commented Jul 8, 2020

The current default behaviour in Tool.ProcessExitCode() is to throw an exception if the exit code is non-zero.

There may be occasions where ignoring the exit code is preferred as additional processing is needed before the underlying error is handled.

For example, when running unit tests with dotnet test (via DotNetCoreTest) in a CI pipeline, rather than failing immediately upon test failure, it might be that uploading the test results would be the way the pipeline recognises the failing tests and then fails the build.

As such, I think it would be useful to have a property in Settings that can be set to enable ignoring exit codes

@bagavan44
Copy link

Yes, it will be very much useful. Facing the issue with same problem. Whenever one of the test is failed then process stopped there it self.

@devlead devlead added this to the v1.0.0 milestone Oct 3, 2020
@devlead
Copy link
Member

devlead commented Oct 3, 2020

Fixed by #2826

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants