GH2825: Add HandleExitCode to ToolSettings #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flcdrg
commented
Jul 8, 2020
flcdrg
commented
- When true, then ProcessExitCode method is not called
devlead
force-pushed
the
ignore-exitcode
branch
from
4e4c71e
to
a073a71
Compare
devlead
reviewed
Sep 7, 2020
- When not set or false, then ProcessExitCode is called (existing behaviour) - When true, then ProcessExitCode method is not called (and optionally alternate behaviour can be implemented)
flcdrg
force-pushed
the
ignore-exitcode
branch
from
a073a71
to
74c0f34
Compare
flcdrg
changed the title
|
@flcdrg your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.