-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseAssemblyInfo does not detect lines with extra spaces #2831
Labels
Milestone
Comments
I'm working on this. |
This was referenced Sep 25, 2020
@karlroyle As you suspected it just needed some adaptions to the regex. In the referenced PR I also extended the unit tests to cover additional whitespaces. |
That's great. Many thanks for your help Dave. |
daveMueller
added a commit
to daveMueller/cake
that referenced
this issue
Sep 26, 2020
daveMueller
added a commit
to daveMueller/cake
that referenced
this issue
Sep 26, 2020
daveMueller
added a commit
to daveMueller/cake
that referenced
this issue
Sep 26, 2020
daveMueller
added a commit
to daveMueller/cake
that referenced
this issue
Sep 27, 2020
daveMueller
added a commit
to daveMueller/cake
that referenced
this issue
Sep 27, 2020
daveMueller
added a commit
to daveMueller/cake
that referenced
this issue
Sep 27, 2020
devlead
added a commit
that referenced
this issue
Oct 2, 2020
🎉 This issue has been resolved in version v1.0.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Loss of AssemblyInfo data when reading from an AssemblyInfo with spaces at the end of lines (outside the quotes)
When parsing the AssemblyInfo files, a regular expression is used, which reads in the lines, such as InternalsVisibleTo()
If a line has a space at the end, but outside the quotes, that line is not read in (and subsequently lost on re-write).
This is on Window 10, Cake 0.38, 64 bit.
I suspect that it just needs an adjustment to the Regex in order to identify lines with additional whitespace.
The text was updated successfully, but these errors were encountered: