Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseAssemblyInfo does not detect lines with extra spaces #2831

Closed
karlroyle opened this issue Jul 17, 2020 · 4 comments · Fixed by #2865
Closed

ParseAssemblyInfo does not detect lines with extra spaces #2831

karlroyle opened this issue Jul 17, 2020 · 4 comments · Fixed by #2865
Milestone

Comments

@karlroyle
Copy link

karlroyle commented Jul 17, 2020

Loss of AssemblyInfo data when reading from an AssemblyInfo with spaces at the end of lines (outside the quotes)

When parsing the AssemblyInfo files, a regular expression is used, which reads in the lines, such as InternalsVisibleTo()
If a line has a space at the end, but outside the quotes, that line is not read in (and subsequently lost on re-write).

This is on Window 10, Cake 0.38, 64 bit.

I suspect that it just needs an adjustment to the Regex in order to identify lines with additional whitespace.

image

@daveMueller
Copy link
Contributor

I'm working on this.

This was referenced Sep 25, 2020
@daveMueller
Copy link
Contributor

@karlroyle As you suspected it just needed some adaptions to the regex. In the referenced PR I also extended the unit tests to cover additional whitespaces.

@karlroyle
Copy link
Author

That's great. Many thanks for your help Dave.

daveMueller added a commit to daveMueller/cake that referenced this issue Sep 26, 2020
daveMueller added a commit to daveMueller/cake that referenced this issue Sep 27, 2020
@devlead devlead added this to the v1.0.0 milestone Oct 2, 2020
@devlead devlead closed this as completed in 26fbcee Oct 2, 2020
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants